Test/df 380 improve notify coverage#207
Merged
whitewaterdesign merged 6 commits intomainfrom Sep 23, 2025
Merged
Conversation
| export interface FormAdapterSubmissionMessageData { | ||
| main: Record<string, RichFormValue> | ||
| main: Record<string, RichFormValue | null> | ||
| repeaters: Record<string, Record<string, RichFormValue>[]> |
Contributor
There was a problem hiding this comment.
Will repeaters not also need to allow nulls?
repeaters: Record<string, Record<string, RichFormValue | null>[]
Contributor
Author
There was a problem hiding this comment.
we can do, it's not set at the moment as there is no requirement
|
davidjamesstone
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
Empty values in main fields on Forms Adapter v1 message are being clipped by
JSON.stringifyandJSON.parse. This ticket replaces theundefinedvalue withnull, to allow correct serialisation for theforms-notify-listener. This can them be turned back intoundefined.Jira ticket: https://eaflood.atlassian.net/browse/DF-512
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).